Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with Frame style "Headers, top and bottom" on v1.1.0 in TB for MAC #1

Closed
bmscmoreira opened this issue Nov 24, 2018 · 6 comments

Comments

@bmscmoreira
Copy link

Frame style "Headers, top and bottom" on v1.1.0 in TB for macOS seems not to be working, as no borders are displayed. Tested with the same version in TB for Windows and it works.
Both TB versions are 60.3.1.

@dreadnaut dreadnaut added the help wanted Help with fixing this is welcome! label Dec 26, 2018
@revad
Copy link

revad commented Mar 31, 2019

Frame style "Headers, top and bottom" does not work on Linux either. Neither does "Headers"
TB v60.5.0. Bordercolors D v1.1.1 SuSE Linux
And indeed it does work on Windows 10 - same versions.
Strange.

@dreadnaut
Copy link
Owner

I don't have a Mac to test on, but I can definitely check on Linux. It's likely that the default styles vary depending on the platform, and our overrides only cover the Windows styles.

@revad revad mentioned this issue Apr 1, 2019
@dreadnaut dreadnaut removed the help wanted Help with fixing this is welcome! label Apr 6, 2019
@dreadnaut
Copy link
Owner

dreadnaut commented Apr 6, 2019

I think I have fixed the issue on Linux, and I have uploaded a new version here on GitHub:
https://github.com/dreadnaut/bordercolors-d/releases/tag/v1.1.2

@bmscmoreira Could you check if the fix also works for MacOS?

About the issue: the default -moz-appearance used for the header sets borders on Linux (and probably MacOS), while it has a flat look on Windows. This meant that the "Headers" styles worked fine on one system, but were overridden by the platform styles on the others.

Solution: reset -moz-appearance when we want to override the borders around the headers, see 5b5b056

@revad
Copy link

revad commented Apr 6, 2019

wfm on Linux

@bmscmoreira
Copy link
Author

Thanks, working on macOS! (only bottom bar is slightly thinner than the others and not completely aligned with the bottom of the header, but not a problem for me)

2019-04-06_08-59-16_PM

@dreadnaut
Copy link
Owner

With the rewrite for TB78, this style cannot be rendered anymore, so I'll close this issue 🙁

If none of the styles in the new version is good enough, let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants