New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(facade): add set font apis and get cell model data api #1266
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #1266 +/- ##
==========================================
+ Coverage 29.63% 29.72% +0.08%
==========================================
Files 843 843
Lines 47792 47859 +67
Branches 9795 9811 +16
==========================================
+ Hits 14162 14224 +62
- Misses 33630 33635 +5 ☔ View full report in Codecov by Sentry. |
View Deployment
|
6720e48
to
7ef994e
Compare
09a5897
to
f9cd97d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! Though minor changes would be appreciated.
style, | ||
}; | ||
|
||
this._commandService.executeCommand(SetStyleCommand.id, setStyleParams); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
把 SetStyleCommand
改成同步的命令吧,然后这里变成 syncExecuteCommand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里参照 Apps Scripts 设计,是链式调用,没有返回调用的状态。 保持异步调用会不会更快?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不会,SetStyleCommand 内部实现就是同步的
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
了解了,后续调整下
54be575
to
14c722e
Compare
* feat(facade): export FontWeight * feat(facade): add getCellData、getCellStyleData、setFontStyle、setFontLine * feat(facade): add setFontFamily * feat(facade): add setFontSize * feat(facade): add setFontColor * fix(sheet): setRangeValues judging null * test(facade): test composite set font style * refactor(facade): refactor set font style
dev
branch.close #1009
Add Facade range APIs: