Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sheet-ui): fix clipboard not available in unsecure context #1345

Merged
merged 2 commits into from Feb 7, 2024
Merged

fix(sheet-ui): fix clipboard not available in unsecure context #1345

merged 2 commits into from Feb 7, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Feb 6, 2024

  • I am sure that the code is update-to-date with the dev branch.

close #1344

@wzhudev wzhudev requested a review from yuhongz as a code owner February 6, 2024 12:02
@wzhudev wzhudev added the qa:untested This PR is ready to be tested label Feb 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024 •
edited

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@codecov Codecov
Copy link

codecov bot commented Feb 6, 2024 •
edited

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9340f54) 29.72% compared to head (14206aa) 29.72%.

Files Patch % Lines
.../services/clipboard/clipboard-interface.service.ts 0.00% 1 Missing ⚠️
...kages/ui/src/services/clipboard/clipboard-utils.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##              dev    #1345   +/-   ##
=======================================
  Coverage   29.72%   29.72%           
=======================================
  Files         844      844           
  Lines       47874    47874           
  Branches     9812     9813    +1     
=======================================
  Hits        14231    14231           
  Misses      33643    33643

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Feb 7, 2024
jikkai
jikkai approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@jikkai jikkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jikkai jikkai merged commit bd57a84 into dev Feb 7, 2024
7 checks passed
@jikkai jikkai deleted the wzhudev/fix-clipboard-insecure branch February 7, 2024 02:44
Dushusir pushed a commit that referenced this pull request Feb 7, 2024
@wzhudev @Dushusir
fix(sheet-ui): fix clipboard not available in unsecure context (#1345)
376c5a0 
* fix(sheet-ui): fix clipboard not available in unsecure context

* docs: add comment
@jikkai jikkai mentioned this pull request Feb 19, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jikkai jikkai jikkai approved these changes

@yuhongz yuhongz Awaiting requested review from yuhongz

Assignees
No one assigned
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Accessing the clipboard from a non-secure address will trigger an error.
2 participants
@wzhudev @jikkai