Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): formula ref move #1359

Merged
merged 2 commits into from Feb 19, 2024
Merged

fix(sheet): formula ref move #1359

merged 2 commits into from Feb 19, 2024

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented Feb 15, 2024

  • I am sure that the code is update-to-date with the dev branch.

close #1291

@DR-Univer DR-Univer added the qa:untested This PR is ready to be tested label Feb 15, 2024
Copy link

github-actions bot commented Feb 15, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@DR-Univer
Copy link
Collaborator Author

撤销的时候,没有触发insert导致undo的范围不对。得查一下 @Dushusir

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


When undoing, insert is not triggered, causing the undo range to be incorrect. Gotta look it up @Dushusir

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b289174) 29.75% compared to head (4a82cc4) 29.75%.
Report is 7 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1359   +/-   ##
=======================================
  Coverage   29.75%   29.75%           
=======================================
  Files         845      845           
  Lines       47931    47931           
  Branches     9832     9832           
=======================================
  Hits        14262    14262           
  Misses      33669    33669           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Feb 19, 2024
@DR-Univer DR-Univer merged commit 65e64bf into dev Feb 19, 2024
7 checks passed
@DR-Univer DR-Univer deleted the fix-formula-ref-move branch February 19, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] move row 偏移不对
3 participants