Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): binary search #1361

Merged
merged 5 commits into from Feb 19, 2024
Merged

fix(sheet): binary search #1361

merged 5 commits into from Feb 19, 2024

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented Feb 16, 2024

  • I am sure that the code is update-to-date with the dev branch.

close #1303

Copy link

github-actions bot commented Feb 16, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (b289174) 29.75% compared to head (8935236) 30.05%.
Report is 14 commits behind head on dev.

Files Patch % Lines
...ngine-formula/src/engine/ast-node/function-node.ts 36.00% 16 Missing ⚠️
...heets-ui/src/services/selection/selection-shape.ts 33.33% 12 Missing ⚠️
...ngine-formula/src/functions/lookup/lookup/index.ts 50.00% 1 Missing ⚠️
...gine-formula/src/functions/lookup/vlookup/index.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1361      +/-   ##
==========================================
+ Coverage   29.75%   30.05%   +0.30%     
==========================================
  Files         845      848       +3     
  Lines       47931    48154     +223     
  Branches     9832     9888      +56     
==========================================
+ Hits        14262    14474     +212     
- Misses      33669    33680      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Feb 19, 2024
@DR-Univer DR-Univer merged commit 23221c4 into dev Feb 19, 2024
7 checks passed
@DR-Univer DR-Univer deleted the fix-binary-search branch February 19, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]lookup公式计算规则
2 participants