Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(facade): add onBeforeCommandExecute API #1370

Merged
merged 1 commit into from Feb 19, 2024
Merged

Conversation

fmwww
Copy link
Contributor

@fmwww fmwww commented Feb 19, 2024

re #1346

  • I am sure that the code is update-to-date with the dev branch.

close #1346

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (0cd5fdf) 29.64% compared to head (ab88a15) 29.64%.

Files Patch % Lines
packages/facade/src/apis/sheet/f-workbook.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1370   +/-   ##
=======================================
  Coverage   29.64%   29.64%           
=======================================
  Files         848      848           
  Lines       48089    48097    +8     
  Branches     9877     9878    +1     
=======================================
+ Hits        14257    14260    +3     
- Misses      33832    33837    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 19, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@wzhudev wzhudev merged commit b842579 into dream-num:dev Feb 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Quick Ticket] add onBeforeCommandExecute on Facade API
2 participants