Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add destroyOnClose for Dialog #1391

Merged
merged 1 commit into from
Feb 20, 2024
Merged

feat: add destroyOnClose for Dialog #1391

merged 1 commit into from
Feb 20, 2024

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Feb 20, 2024

  • I am sure that the code is update-to-date with the dev branch.

@jikkai jikkai requested a review from wzhudev as a code owner February 20, 2024 07:45
Copy link

github-actions bot commented Feb 20, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (71fc6b0) 31.48% compared to head (c4dd3b1) 31.48%.

Files Patch % Lines
packages/design/src/components/dialog/Dialog.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1391      +/-   ##
==========================================
- Coverage   31.48%   31.48%   -0.01%     
==========================================
  Files         858      858              
  Lines       48627    48628       +1     
  Branches    10049    10050       +1     
==========================================
  Hits        15312    15312              
- Misses      33315    33316       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai merged commit a6e17ef into dev Feb 20, 2024
7 checks passed
@jikkai jikkai deleted the feat/dialog-destroy branch February 20, 2024 07:49
weird94 added a commit that referenced this pull request Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant