Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-ui): dynamically adjust row header width #1475

Merged
merged 1 commit into from Mar 5, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Mar 5, 2024

close #1471

  • I am sure that the code is update-to-date with the dev branch.

@wzhudev wzhudev requested a review from DR-Univer as a code owner March 5, 2024 02:22
Copy link

github-actions bot commented Mar 5, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@wzhudev
Copy link
Member Author

wzhudev commented Mar 5, 2024

This change mimic Microsoft Excel who would update the row header width when the count of rows changes.

image

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 32.58%. Comparing base (885ba4b) to head (06ebbbe).

Files Patch % Lines
...ine-render/src/components/sheets/sheet-skeleton.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1475      +/-   ##
==========================================
- Coverage   32.59%   32.58%   -0.01%     
==========================================
  Files         905      905              
  Lines       50121    50125       +4     
  Branches    10431    10431              
==========================================
  Hits        16335    16335              
- Misses      33786    33790       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev added the qa:untested This PR is ready to be tested label Mar 5, 2024
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Mar 5, 2024
@zhaolixin7
Copy link

todo @zhaolixin7 合入staging后验证

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


todo @zhaolixin7 Verify after integrating into staging

@zhaolixin7 zhaolixin7 removed the qa:untested This PR is ready to be tested label Mar 5, 2024
@wzhudev wzhudev merged commit 371b4f1 into dev Mar 5, 2024
7 checks passed
@wzhudev wzhudev deleted the wzhudev/fix-row-header-width branch March 5, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] 表格行数超过百万时,行号数溢出
4 participants