Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): fix unreasonable merged selections #1477

Merged
merged 2 commits into from Mar 5, 2024

Conversation

ybzky
Copy link
Contributor

@ybzky ybzky commented Mar 5, 2024

  • I am sure that the code is update-to-date with the dev branch.

close #1357

@ybzky ybzky requested a review from Gggpound March 5, 2024 06:38
Copy link

github-actions bot commented Mar 5, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 32.62%. Comparing base (885ba4b) to head (fae073d).
Report is 4 commits behind head on dev.

Files Patch % Lines
...-ui/src/commands/commands/utils/selection-utils.ts 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1477      +/-   ##
==========================================
+ Coverage   32.59%   32.62%   +0.03%     
==========================================
  Files         905      905              
  Lines       50121    50146      +25     
  Branches    10431    10439       +8     
==========================================
+ Hits        16335    16359      +24     
- Misses      33786    33787       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gggpound Gggpound added the qa:untested This PR is ready to be tested label Mar 5, 2024
@zhaolixin7 zhaolixin7 assigned ybzky and unassigned zhaolixin7 Mar 5, 2024
@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Mar 5, 2024
@wzhudev wzhudev merged commit bd8c5df into dev Mar 5, 2024
9 checks passed
@wzhudev wzhudev deleted the fix-invalid-merge-selection branch March 5, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] 如果只有一个单元格的情况下,合并单元格应该不能设置
4 participants