Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(collaboration): move snapshot transform to core #1519

Merged
merged 3 commits into from Mar 9, 2024

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Mar 8, 2024

  • I am sure that the code is update-to-date with the dev branch.

close #

  • move snapshot transform to core

@Dushusir Dushusir force-pushed the dushusir/transform-snapshot branch from a620221 to b204f94 Compare March 8, 2024 08:55
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 56.21891% with 88 lines in your changes are missing coverage. Please review.

Project coverage is 32.93%. Comparing base (91397c6) to head (32c06b9).

Files Patch % Lines
...s/core/src/services/snapshot/snapshot-transform.ts 57.39% 49 Missing ⚠️
...e/src/services/snapshot/snapshot-server.service.ts 0.00% 21 Missing ⚠️
...kages/core/src/services/snapshot/snapshot-utils.ts 73.21% 15 Missing ⚠️
packages/core/src/shared/coder.ts 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1519      +/-   ##
==========================================
+ Coverage   32.78%   32.93%   +0.14%     
==========================================
  Files         913      917       +4     
  Lines       50803    51003     +200     
  Branches    10592    10618      +26     
==========================================
+ Hits        16656    16797     +141     
- Misses      34147    34206      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 8, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Dushusir Dushusir marked this pull request as ready for review March 8, 2024 09:05
@Dushusir Dushusir force-pushed the dushusir/transform-snapshot branch from 1312d07 to 32c06b9 Compare March 9, 2024 09:25
@Dushusir Dushusir merged commit 6557ea5 into dev Mar 9, 2024
7 checks passed
@Dushusir Dushusir deleted the dushusir/transform-snapshot branch March 9, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants