Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): first sheet hidden #1538

Merged
merged 2 commits into from Mar 11, 2024
Merged

fix(sheet): first sheet hidden #1538

merged 2 commits into from Mar 11, 2024

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented Mar 11, 2024

  • If the first sheet is hidden, we should set the first unhidden sheet to be active.

close #

@DR-Univer DR-Univer requested a review from wzhudev as a code owner March 11, 2024 03:38
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Mar 11, 2024
Copy link

github-actions bot commented Mar 11, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 32.93%. Comparing base (e0b49cc) to head (d6eacb9).

Files Patch % Lines
packages/core/src/sheets/workbook.ts 63.63% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1538   +/-   ##
=======================================
  Coverage   32.92%   32.93%           
=======================================
  Files         919      919           
  Lines       51083    51089    +6     
  Branches    10627    10628    +1     
=======================================
+ Hits        16820    16825    +5     
- Misses      34263    34264    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DR-Univer DR-Univer merged commit 6123772 into dev Mar 11, 2024
8 checks passed
@DR-Univer DR-Univer deleted the fix-first-sheet-hidden branch March 11, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:untested This PR is ready to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants