Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): add OR/TEXT/LEN functions #1593

Merged
merged 6 commits into from Mar 19, 2024
Merged

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Mar 15, 2024

  • I am sure that the code is update-to-date with the dev branch.

close #1587
close #1589

Copy link

github-actions bot commented Mar 15, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 83.05085% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 32.91%. Comparing base (7fb6d35) to head (254a505).
Report is 3 commits behind head on dev.

Files Patch % Lines
...es/engine-formula/src/functions/text/text/index.ts 73.33% 8 Missing ⚠️
...ges/engine-formula/src/functions/text/len/index.ts 83.33% 3 Missing ⚠️
...es/engine-formula/src/functions/text/lenb/index.ts 84.21% 3 Missing ⚠️
.../engine-formula/src/engine/ast-node/suffix-node.ts 0.00% 2 Missing ⚠️
...ormula/src/engine/value-object/primitive-object.ts 60.00% 2 Missing ⚠️
...s/engine-formula/src/functions/logical/or/index.ts 91.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1593      +/-   ##
==========================================
+ Coverage   32.80%   32.91%   +0.10%     
==========================================
  Files         927      933       +6     
  Lines       52259    52382     +123     
  Branches    10911    10959      +48     
==========================================
+ Hits        17144    17239      +95     
- Misses      35115    35143      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dushusir Dushusir force-pushed the dushusir/formula-from-xlsx branch 2 times, most recently from 3210ab9 to 37acb36 Compare March 15, 2024 11:03
@Dushusir Dushusir marked this pull request as ready for review March 18, 2024 11:45
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Mar 18, 2024
@Dushusir Dushusir changed the title fix(formula): date default format fix(formula): add OR/TEXT/LEN functions Mar 18, 2024
@DR-Univer DR-Univer merged commit c26eed1 into dev Mar 19, 2024
8 checks passed
@DR-Univer DR-Univer deleted the dushusir/formula-from-xlsx branch March 19, 2024 06:31
ybzky pushed a commit that referenced this pull request Mar 19, 2024
* fix(formula): date default format

* feat(formula): add or function

* fix(formula): create StringValueObject

* feat(formual): add text function

* feat(formula): add len,lenb functions

* fix(formula): index row number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:untested This PR is ready to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Formulas From Imported XLSX Files [Bug] TODAY等日期函数格式设置
2 participants