Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(formula): optimize dependency calculate and array value object compare #1629

Merged
merged 10 commits into from Mar 19, 2024

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented Mar 18, 2024

  1. dependency calculate
  2. optimize arrayValueObject compare method

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 34.16149% with 106 lines in your changes are missing coverage. Please review.

Project coverage is 32.80%. Comparing base (e4231eb) to head (6360d70).
Report is 10 commits behind head on dev.

Files Patch % Lines
...e-formula/src/engine/dependency/dependency-tree.ts 0.00% 46 Missing ⚠️
...ormula/src/engine/dependency/formula-dependency.ts 0.00% 30 Missing ⚠️
...mula/src/engine/value-object/array-value-object.ts 61.22% 19 Missing ⚠️
...c/engine/reference-object/base-reference-object.ts 50.00% 4 Missing ⚠️
...ngine-formula/src/services/current-data.service.ts 66.66% 4 Missing ⚠️
...engine/reference-object/column-reference-object.ts 0.00% 1 Missing ⚠️
...rc/engine/reference-object/row-reference-object.ts 0.00% 1 Missing ⚠️
...rmula/src/engine/value-object/base-value-object.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1629      +/-   ##
==========================================
+ Coverage   32.47%   32.80%   +0.32%     
==========================================
  Files         926      927       +1     
  Lines       52233    52336     +103     
  Branches    10901    10946      +45     
==========================================
+ Hits        16964    17168     +204     
+ Misses      35269    35168     -101     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DR-Univer DR-Univer changed the title Pef formula optimize perf(formula): optimize dependency calculate and array value object compare Mar 18, 2024
Copy link

github-actions bot commented Mar 18, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@DR-Univer DR-Univer merged commit d884ee0 into dev Mar 19, 2024
7 checks passed
@DR-Univer DR-Univer deleted the pef-formula-optimize branch March 19, 2024 06:30
ybzky pushed a commit that referenced this pull request Mar 19, 2024
…ompare (#1629)

* perf(formula): decrease tree node

* fix(formula): optimize array value object

* fix(formula): type error

* fix(sheet): type error

* fix(sheet): type error

* fix(formula): type error

* fix(formula): type error

* fix(formula): delete sheet name for array

* fix(formula): decrease code

* fix(formula): type error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants