Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): index function supports reference object #1657

Merged
merged 4 commits into from Mar 23, 2024

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Mar 21, 2024

  • INDEX/OFFSET function supports reference object
  • TEXT function returns formatted value

@Dushusir Dushusir changed the title Dushusir/formula xlsx import fix(formula): index function supports reference object Mar 21, 2024
@univer-bot
Copy link

univer-bot bot commented Mar 22, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Expected results after moving formula selection #ref

https://github-production-user-asset-6210df.s3.amazonaws.com/154207126/301752594-4246b7d8-04f5-4f86-b6b1-366ab1948984.webm?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz- Credential=AKIAVCODYLSA53PQK4ZA%2F20240322%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20240322T075641Z&X-Amz-Expires=300&X-Amz-Signature=4dc4c8e7675292060b0c2ff 4da154bda0c641951d83be478967e8b16a5e42510&X-Amz-SignedHeaders=host&actor_id=26371161&key_id=0&repo_id=543101941

Copy link

github-actions bot commented Mar 23, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 23, 2024

Codecov Report

Attention: Patch coverage is 90.58824% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 32.80%. Comparing base (a875a31) to head (4d1cdd1).

Files Patch % Lines
...ngine-formula/src/functions/lookup/offset/index.ts 73.33% 4 Missing ⚠️
...ages/engine-formula/src/functions/base-function.ts 88.00% 3 Missing ⚠️
...engine-formula/src/functions/lookup/index/index.ts 97.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1657      +/-   ##
==========================================
+ Coverage   32.75%   32.80%   +0.05%     
==========================================
  Files         951      952       +1     
  Lines       53329    53381      +52     
  Branches    11129    11143      +14     
==========================================
+ Hits        17466    17512      +46     
- Misses      35863    35869       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dushusir Dushusir force-pushed the dushusir/formula-xlsx-import branch from c36df15 to 4d1cdd1 Compare March 23, 2024 12:21
@Dushusir Dushusir marked this pull request as ready for review March 23, 2024 12:25
@Dushusir Dushusir merged commit b47487a into dev Mar 23, 2024
8 checks passed
@Dushusir Dushusir deleted the dushusir/formula-xlsx-import branch March 23, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants