Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): index function handles base value object #1692

Merged
merged 4 commits into from Mar 28, 2024

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Mar 26, 2024

  • OFFSET function supports single value object and array
  • VLOOKUP supports array
  • fix sheet bar right menu position error

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 91.19497% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 31.78%. Comparing base (9abc7c5) to head (5586037).
Report is 1 commits behind head on dev.

Files Patch % Lines
...engine-formula/src/functions/lookup/index/index.ts 80.00% 5 Missing ⚠️
...gine-formula/src/functions/lookup/vlookup/index.ts 89.13% 5 Missing ⚠️
...c/engine/reference-object/base-reference-object.ts 77.77% 2 Missing ⚠️
...ngine-formula/src/functions/lookup/offset/index.ts 96.42% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           dev    #1692       +/-   ##
========================================
+ Coverage     0   31.78%   +31.78%     
========================================
  Files        0     1041     +1041     
  Lines        0    57841    +57841     
  Branches     0    12164    +12164     
========================================
+ Hits         0    18387    +18387     
- Misses       0    39454    +39454     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 28, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Dushusir Dushusir marked this pull request as ready for review March 28, 2024 09:16
@Dushusir Dushusir merged commit 1f0b700 into dev Mar 28, 2024
8 checks passed
@Dushusir Dushusir deleted the dushusir/formula-index-2 branch March 28, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants