Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): use ref range formula #1694

Merged
merged 13 commits into from Apr 9, 2024
Merged

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Mar 26, 2024

close #963
close #1086
close #1129

Reference Ticket #1659

修复导入后公式 si 未识别公式问题

image

Copy link

github-actions bot commented Mar 26, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 62.74510% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 29.77%. Comparing base (03f4668) to head (5b85403).

Files Patch % Lines
...es/engine-formula/src/models/formula-data.model.ts 30.23% 30 Missing ⚠️
...gine-formula/src/models/utils/formula-data-util.ts 76.66% 7 Missing ⚠️
...ine-formula/src/controller/calculate.controller.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1694      +/-   ##
==========================================
+ Coverage   29.76%   29.77%   +0.01%     
==========================================
  Files        1159     1160       +1     
  Lines       62843    62869      +26     
  Branches    13195    13215      +20     
==========================================
+ Hits        18703    18722      +19     
- Misses      44140    44147       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dushusir Dushusir force-pushed the dushusir/update-formula-offset branch 3 times, most recently from eafbce3 to cb1bf92 Compare April 2, 2024 02:03
@Dushusir Dushusir marked this pull request as ready for review April 2, 2024 02:07
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Apr 2, 2024
@Dushusir Dushusir marked this pull request as draft April 2, 2024 02:07
@Dushusir Dushusir removed the qa:untested This PR is ready to be tested label Apr 2, 2024
@Dushusir Dushusir force-pushed the dushusir/update-formula-offset branch 4 times, most recently from 06e458a to 81007fc Compare April 8, 2024 08:11
@Dushusir Dushusir marked this pull request as ready for review April 8, 2024 08:13
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Apr 8, 2024
@univer-bot
Copy link

univer-bot bot commented Apr 8, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Origin Title: fix(formula): use ref range formula

Title: fix(formula): use ref range formula


close #963
close #1086
close #1129

Reference Ticket #1659

修复导入后公式 si 未识别公式问题

image

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Apr 8, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Apr 8, 2024
@Dushusir Dushusir force-pushed the dushusir/update-formula-offset branch from ef667d9 to 5b85403 Compare April 9, 2024 09:59
@Dushusir Dushusir merged commit d8f1dc4 into dev Apr 9, 2024
8 checks passed
@Dushusir Dushusir deleted the dushusir/update-formula-offset branch April 9, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
3 participants