Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(render): media change for refresh canvas #1697

Merged
merged 6 commits into from Mar 28, 2024
Merged

fix(render): media change for refresh canvas #1697

merged 6 commits into from Mar 28, 2024

Conversation

DR-Univer
Copy link
Collaborator

close #1696

@DR-Univer DR-Univer requested a review from wzhudev as a code owner March 26, 2024 07:27
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Mar 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 26, 2024 •
edited

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@codecov Codecov
Copy link

codecov bot commented Mar 26, 2024 •
edited

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 31.62%. Comparing base (dbb918d) to head (8fd8c0d).

Files Patch % Lines
packages/engine-render/src/engine.ts 0.00% 15 Missing ⚠️
...engine-render/src/components/sheets/spreadsheet.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #1697      +/-   ##
==========================================
- Coverage   31.63%   31.62%   -0.01%     
==========================================
  Files        1041     1041              
  Lines       57727    57739      +12     
  Branches    12120    12121       +1     
==========================================
  Hits        18260    18260              
- Misses      39467    39479      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Mar 28, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Mar 28, 2024
wzhudev
wzhudev approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit dd6bfed into dev Mar 28, 2024
8 checks passed
@wzhudev wzhudev deleted the fix-render-media-change branch March 28, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzhudev wzhudev wzhudev approved these changes

Assignees
No one assigned
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Moving from resolution 150% to 125% renders abnormally
3 participants
@DR-Univer @wzhudev @zhaolixin7