Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets): fix shallow copy bugs of the sheet snapshot #1742

Merged
merged 2 commits into from Mar 29, 2024

Conversation

karlsbeard
Copy link
Contributor

  • fix: change the _snapshot of the workbook to deep clone to avoid the side effects when you new an empty sheet.

@karlsbeard karlsbeard requested a review from jikkai March 29, 2024 09:01
Copy link

github-actions bot commented Mar 29, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 31.62%. Comparing base (9ab34b6) to head (b46ea93).
Report is 17 commits behind head on dev.

Files Patch % Lines
packages/core/src/sheets/workbook.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1742      +/-   ##
==========================================
- Coverage   32.33%   31.62%   -0.72%     
==========================================
  Files         976     1044      +68     
  Lines       54152    57883    +3731     
  Branches    11284    12170     +886     
==========================================
+ Hits        17511    18305     +794     
- Misses      36641    39578    +2937     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karlsbeard karlsbeard marked this pull request as ready for review March 29, 2024 09:12
@karlsbeard karlsbeard requested a review from jikkai March 29, 2024 10:31
@jikkai jikkai merged commit 83d910c into dev Mar 29, 2024
8 checks passed
@jikkai jikkai deleted the fix-sheet-snapshot branch March 29, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants