Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(formula): copy paste range with formulas #1765

Merged
merged 3 commits into from Apr 8, 2024
Merged

fix(formula): copy paste range with formulas #1765

merged 3 commits into from Apr 8, 2024

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Apr 2, 2024 •
edited

close #1394
close #1406

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024 •
edited

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@codecov Codecov
Copy link

codecov bot commented Apr 2, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.71%. Comparing base (fc4cc4c) to head (71eaca8).
Report is 3 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #1765      +/-   ##
==========================================
+ Coverage   29.68%   29.71%   +0.03%     
==========================================
  Files        1158     1158              
  Lines       62778    62787       +9     
  Branches    13177    13179       +2     
==========================================
+ Hits        18634    18656      +22     
+ Misses      44144    44131      -13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dushusir Dushusir marked this pull request as ready for review April 2, 2024 07:48
@Dushusir Dushusir requested a review from DR-Univer as a code owner April 2, 2024 07:48
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Apr 2, 2024
@Dushusir Dushusir removed the qa:untested This PR is ready to be tested label Apr 2, 2024
@Dushusir Dushusir marked this pull request as draft April 2, 2024 08:45
@Dushusir Dushusir marked this pull request as ready for review April 2, 2024 11:52
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Apr 2, 2024
@zhaolixin7
Copy link

zhaolixin7 commented Apr 7, 2024 •
edited

@Dushusir 向上填充公式引用部分未被填充
2024_4_7 14_13_01 video.webm

@univer-bot
Copy link

univer-bot bot commented Apr 7, 2024 •
edited

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@Dushusir Fill up the formula reference part is not filled
2024_4_7 14_13_01 video.webm

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Apr 7, 2024
@Dushusir Dushusir added qa:untested This PR is ready to be tested and removed qa:rejected labels Apr 8, 2024
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Apr 8, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Apr 8, 2024
@Dushusir Dushusir merged commit 58c7d3e into dev Apr 8, 2024
8 checks passed
@Dushusir Dushusir deleted the dushusir/formula-bug-0402 branch April 8, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DR-Univer DR-Univer DR-Univer approved these changes

Assignees
No one assigned
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Milestone
No milestone
3 participants
@Dushusir @zhaolixin7 @DR-Univer