feat(facade): sheet api getId rename to getSheetId #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1770 +/- ##
=======================================
Coverage 29.65% 29.65%
=======================================
Files 1138 1138
Lines 61865 61865
Branches 12940 12940
=======================================
Hits 18349 18349
Misses 43516 43516 ☔ View full report in Codecov by Sentry. |
hexf00
changed the title
hexf00
changed the title
jikkai
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to reduce the learning cost for facade API users, it is expected to align with the Google Apps Script API, https://developers.google.com/apps-script/reference/spreadsheet/sheet#getSheetId()
#1762