New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): refactoring resources load and snapshot #1853
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gggpound
force-pushed
the
gggpound/refactory-resources-0410
branch
2 times, most recently
from
April 10, 2024 10:21
cdd0213
to
9d17156
Compare
wzhudev
reviewed
Apr 10, 2024
wzhudev
reviewed
Apr 10, 2024
packages/sheets/src/controllers/defined-name-data.controller.ts
Outdated
Show resolved
Hide resolved
2 tasks
Gggpound
force-pushed
the
gggpound/refactory-resources-0410
branch
2 times, most recently
from
April 12, 2024 12:32
ce341d7
to
64d4561
Compare
Gggpound
changed the title
Gggpound/refactory resources 0410
feat(core): refactoring resources load and snapshot
Apr 12, 2024
Gggpound
force-pushed
the
gggpound/refactory-resources-0410
branch
from
April 12, 2024 12:58
3b9e75e
to
48dbf62
Compare
View Deployment
|
Gggpound
force-pushed
the
gggpound/refactory-resources-0410
branch
from
April 13, 2024 06:37
64579df
to
e6b3e2a
Compare
wzhudev
reviewed
Apr 13, 2024
wzhudev
approved these changes
Apr 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Gggpound
force-pushed
the
gggpound/refactory-resources-0410
branch
from
April 13, 2024 09:42
ebfbec4
to
b2f4f88
Compare
Gggpound
added
qa:untested
This PR is ready to be tested
qa:verified
This PR has already by verified by a QA and is considered good enough to be merge
and removed
qa:untested
This PR is ready to be tested
labels
Apr 13, 2024
Gggpound
force-pushed
the
gggpound/refactory-resources-0410
branch
from
April 13, 2024 12:25
1f85948
to
4d645a4
Compare
Gggpound
force-pushed
the
gggpound/refactory-resources-0410
branch
from
April 13, 2024 12:39
4d645a4
to
fc106e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
qa:verified
This PR has already by verified by a QA and is considered good enough to be merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1880