Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): refactoring resources load and snapshot #1853

Merged
merged 13 commits into from Apr 13, 2024

Conversation

Gggpound
Copy link
Contributor

@Gggpound Gggpound commented Apr 10, 2024

close #1880

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 21.60000% with 98 lines in your changes are missing coverage. Please review.

Project coverage is 29.58%. Comparing base (70d3a7e) to head (fc106e1).
Report is 1 commits behind head on dev.

Files Patch % Lines
...re/src/services/resource-loader/resource-loader.ts 34.14% 27 Missing ⚠️
...vices/resource-manager/resource-manager.service.ts 19.35% 25 Missing ⚠️
...kages/sheets/src/services/numfmt/numfmt.service.ts 0.00% 13 Missing ⚠️
...lidation/src/controllers/dv-resource.controller.ts 0.00% 10 Missing ⚠️
...ing/src/services/conditional-formatting.service.ts 0.00% 9 Missing ⚠️
...ts/src/controllers/defined-name-data.controller.ts 0.00% 6 Missing ⚠️
...gine-formula/src/services/defined-names.service.ts 25.00% 3 Missing ⚠️
...ata-validation/src/models/data-validation-model.ts 0.00% 2 Missing ⚠️
...ng/src/models/conditional-formatting-rule-model.ts 0.00% 2 Missing ⚠️
...ackages/sheets-data-validation/src/common/const.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1853   +/-   ##
=======================================
  Coverage   29.57%   29.58%           
=======================================
  Files        1169     1171    +2     
  Lines       63651    63660    +9     
  Branches    13464    13465    +1     
=======================================
+ Hits        18827    18836    +9     
  Misses      44824    44824           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gggpound Gggpound marked this pull request as draft April 10, 2024 10:09
@Gggpound Gggpound force-pushed the gggpound/refactory-resources-0410 branch 2 times, most recently from cdd0213 to 9d17156 Compare April 10, 2024 10:21
@Gggpound Gggpound force-pushed the gggpound/refactory-resources-0410 branch 2 times, most recently from ce341d7 to 64d4561 Compare April 12, 2024 12:32
@Gggpound Gggpound changed the title Gggpound/refactory resources 0410 feat(core): refactoring resources load and snapshot Apr 12, 2024
@Gggpound Gggpound marked this pull request as ready for review April 12, 2024 12:57
@Gggpound Gggpound force-pushed the gggpound/refactory-resources-0410 branch from 3b9e75e to 48dbf62 Compare April 12, 2024 12:58
Copy link

github-actions bot commented Apr 12, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Gggpound Gggpound force-pushed the gggpound/refactory-resources-0410 branch from 64579df to e6b3e2a Compare April 13, 2024 06:37
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gggpound Gggpound force-pushed the gggpound/refactory-resources-0410 branch from ebfbec4 to b2f4f88 Compare April 13, 2024 09:42
@Gggpound Gggpound added qa:untested This PR is ready to be tested qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Apr 13, 2024
@Gggpound Gggpound force-pushed the gggpound/refactory-resources-0410 branch from 1f85948 to 4d645a4 Compare April 13, 2024 12:25
@Gggpound Gggpound force-pushed the gggpound/refactory-resources-0410 branch from 4d645a4 to fc106e1 Compare April 13, 2024 12:39
@Gggpound Gggpound merged commit 8ae91b7 into dev Apr 13, 2024
8 checks passed
@Gggpound Gggpound deleted the gggpound/refactory-resources-0410 branch April 13, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
2 participants