Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet-formula): fix error message on missing formula #1885

Merged
merged 1 commit into from Apr 13, 2024

Conversation

DR-Univer
Copy link
Collaborator

close #1505

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Apr 12, 2024
Copy link

github-actions bot commented Apr 12, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 29.65%. Comparing base (21d145c) to head (2f3b0ac).

Files Patch % Lines
...gine-formula/src/engine/ast-node/reference-node.ts 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1885      +/-   ##
==========================================
+ Coverage   29.58%   29.65%   +0.07%     
==========================================
  Files        1165     1165              
  Lines       63239    63242       +3     
  Branches    13312    13313       +1     
==========================================
+ Hits        18707    18754      +47     
+ Misses      44532    44488      -44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Apr 13, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Apr 13, 2024
@wzhudev wzhudev changed the title fix(sheet): formula name not exist tip fix(sheet-formula): fix error message on missing formula Apr 13, 2024
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit 0ab866e into dev Apr 13, 2024
9 checks passed
@wzhudev wzhudev deleted the fix-function-name-error branch April 13, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] 不支持的公式会报#SPILL! ,预期报#n/a或#value
3 participants