Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data-validation): transform support for data validation #1915

Merged
merged 99 commits into from Apr 22, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Apr 15, 2024

close #1882, #1883, #1884

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 157 lines in your changes are missing coverage. Please review.

Project coverage is 29.60%. Comparing base (ee8f8de) to head (e80a274).

Files Patch % Lines
...s-data-validation/src/validators/list-validator.ts 0.00% 48 Missing ⚠️
...ion/src/views/formula-input/list-formula-input.tsx 0.00% 37 Missing ⚠️
...ata-validation/src/models/data-validation-model.ts 0.00% 14 Missing ⚠️
...a-validation/src/models/data-validation-manager.ts 0.00% 13 Missing ⚠️
packages/design/src/components/popup/RectPopup.tsx 0.00% 12 Missing ⚠️
...dation/src/models/sheet-data-validation-manager.ts 0.00% 12 Missing ⚠️
...alidation/src/services/register-formula.service.ts 0.00% 7 Missing ⚠️
.../sheets-data-validation/src/views/detail/index.tsx 0.00% 6 Missing ⚠️
...validation/src/widgets/dropdown-multiple-widget.ts 0.00% 3 Missing ⚠️
packages/data-validation/src/common/util.ts 0.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1915      +/-   ##
==========================================
+ Coverage   29.59%   29.60%   +0.01%     
==========================================
  Files        1179     1179              
  Lines       64277    64252      -25     
  Branches    13616    13611       -5     
==========================================
  Hits        19024    19024              
+ Misses      45253    45228      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weird94 weird94 changed the title feat: transform support for data validation feat(data-validation): transform support for data validation Apr 16, 2024
@wzhudev wzhudev added the qa:untested This PR is ready to be tested label Apr 16, 2024
Copy link

github-actions bot commented Apr 16, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Apr 17, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Apr 17, 2024
@weird94 weird94 merged commit 22ccbb1 into dev Apr 22, 2024
8 checks passed
@weird94 weird94 deleted the feat/transform-data-validation branch April 22, 2024 07:57
Gggpound pushed a commit that referenced this pull request Apr 22, 2024
* feat: add-range & delete-range support spillable ref-range strategy

* feat: ref-range

* feat: move resource and sheet controller to data-validation pkg

* fix: unique editor id

* fix: eslint

* feat: lock

* fix: move-range

* fix: css

* feat: add ref-range tldr pic

* feat: test

* feat: ref-range unit testt

* fix: redi warning

* feat: lint

* feat: build

* feat: move mark-dirty mutation to dv-pkg

* feat: add dayjs default plugin

* feat: text-length i18n

* feat: rename ref-range util

* feat: rename

* feat: support data-validation transform

* feat: data-validation list support formula

* feat: remove useless code

* feat: dv-demo

* fix: build

* feat: delay load data validation resource on web app

* feat: build fix

* fix: build

* feat: lint

* feat: add unitId bind

* feat: subUnitId

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* fix: empty range

* feat: update

* feat: add polyfill of old version

* feat: update

* feat: update

* feat: update

* feat: update

* feat: fix deps issue

* feat: style update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: lock

* feat: build

* feat: temp

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: test

* feat: update

* fix: fix lockfile

* fix: popup

* feat: locale

* feat: lint

---------

Co-authored-by: 白熱 <sonne@asaki.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
5 participants