Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix univer plugin lifecycle not triggered #2023

Merged
merged 2 commits into from Apr 20, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Apr 20, 2024

No description provided.

Copy link

github-actions bot commented Apr 20, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Apr 20, 2024

Codecov Report

Attention: Patch coverage is 56.09756% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 29.60%. Comparing base (5b0a103) to head (b716b36).

Files Patch % Lines
...ackages/core/src/services/plugin/plugin.service.ts 53.57% 13 Missing ⚠️
packages/core/src/services/plugin/plugin-holder.ts 66.66% 3 Missing ⚠️
packages/core/src/univer.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2023   +/-   ##
=======================================
  Coverage   29.59%   29.60%           
=======================================
  Files        1179     1179           
  Lines       64278    64282    +4     
  Branches    13616    13617    +1     
=======================================
+ Hits        19024    19031    +7     
+ Misses      45254    45251    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev merged commit 827e5a3 into dev Apr 20, 2024
8 checks passed
@wzhudev wzhudev deleted the wzhudev/fix-univer-plugin-lifecycle branch April 20, 2024 11:24
Gggpound pushed a commit that referenced this pull request Apr 22, 2024
* fix: fix univer plugin lifecycle not triggered

* feat: add start API on Univer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant