Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(facade): fix handling of empty selections in onSelectionChange method #2066

Merged
merged 1 commit into from Apr 24, 2024

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Apr 24, 2024

No description provided.

Copy link
Member

@hexf00 hexf00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 29.71%. Comparing base (283d1b3) to head (2977e0d).
Report is 1 commits behind head on dev.

❗ Current head 2977e0d differs from pull request most recent head 939cfa4. Consider uploading reports for the commit 939cfa4 to get more accurate results

Files Patch % Lines
packages/facade/src/apis/sheets/f-workbook.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2066      +/-   ##
==========================================
- Coverage   29.71%   29.71%   -0.01%     
==========================================
  Files        1178     1178              
  Lines       63981    63982       +1     
  Branches    13588    13589       +1     
==========================================
  Hits        19011    19011              
- Misses      44970    44971       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai force-pushed the fix/facade-on-selection-change branch from d1024c2 to 939cfa4 Compare April 24, 2024 16:25
Copy link

github-actions bot commented Apr 24, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@jikkai jikkai merged commit e440e04 into dev Apr 24, 2024
9 checks passed
@jikkai jikkai deleted the fix/facade-on-selection-change branch April 24, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants