fix(sheet-formula): store themeColor to reuse #2079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Origin Title: fix(sheet-formula): store themeColor to reuse Title: fix(sheet-formula): store themeColor to reuse This PR is related to #2007. It only fixes the problem of using multiple colors for the same token. There is another problem. I think another PR can be opened to fix it. Before:
After:
|
View Deployment
|
2 tasks
DR-Univer
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 和 #2007 相关，这里只修复了同样的 token 使用了多个颜色的问题，另外还存在的一个问题，我觉得可以另开一个 PR 进行修复。
Before:
After: