Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix unit cannot be destroyed or recreate #2081

Merged
merged 2 commits into from Apr 26, 2024
Merged

fix: fix unit cannot be destroyed or recreate #2081

merged 2 commits into from Apr 26, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Apr 26, 2024

No description provided.

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 31.04%. Comparing base (fa4ebea) to head (6a9d603).

Files Patch % Lines
...ets-ui/src/controllers/freeze.render-controller.ts 0.00% 4 Missing ⚠️
...es/engine-render/src/render-manager/render-unit.ts 0.00% 2 Missing ⚠️
...sheets-ui/src/controllers/utils/component-tools.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2081      +/-   ##
==========================================
- Coverage   31.04%   31.04%   -0.01%     
==========================================
  Files        1207     1207              
  Lines       66148    66150       +2     
  Branches    13993    13993              
==========================================
  Hits        20534    20534              
- Misses      45614    45616       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Apr 26, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@wzhudev wzhudev merged commit b67a9f8 into dev Apr 26, 2024
9 checks passed
@wzhudev wzhudev deleted the fix/unit-dispose branch April 26, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant