Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move row&col effects on filter-range #2284

Merged
merged 4 commits into from
May 27, 2024
Merged

Conversation

yuhongz
Copy link
Contributor

@yuhongz yuhongz commented May 21, 2024

close this issue

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@yuhongz yuhongz requested a review from ybzky as a code owner May 21, 2024 06:59
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label May 21, 2024
@yuhongz yuhongz requested a review from wzhudev May 21, 2024 07:01
Copy link

github-actions bot commented May 21, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 30.02%. Comparing base (1e2b4c3) to head (8f630b4).
Report is 1 commits behind head on dev.

Files Patch % Lines
...-ui/src/controllers/sheets-filter-ui.controller.ts 0.00% 7 Missing ⚠️
...filter/src/controllers/sheets-filter.controller.ts 84.61% 6 Missing ⚠️
...sheets-filter/src/services/sheet-filter.service.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2284      +/-   ##
==========================================
+ Coverage   29.99%   30.02%   +0.02%     
==========================================
  Files        1419     1419              
  Lines       72976    73016      +40     
  Branches    15283    15297      +14     
==========================================
+ Hits        21892    21921      +29     
- Misses      51084    51095      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo
Copy link

往回拖拽时,会缩小筛选范围,预期筛选区域不变
2024_5_21 16_41_41 video.webm

@univer-bot
Copy link

univer-bot bot commented May 21, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

When dragging back, the filtering range will be narrowed and the expected filtering area will remain unchanged.
2024_5_21 16_41_41 video.webm

@oumomomo oumomomo added qa:rejected and removed qa:untested This PR is ready to be tested labels May 21, 2024
@yuhongz yuhongz added the qa:untested This PR is ready to be tested label May 26, 2024
@univer-bot univer-bot bot removed the qa:rejected label May 26, 2024
@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label May 27, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label May 27, 2024
@wzhudev
Copy link
Member

wzhudev commented May 27, 2024

Unit tests should be added in the future.

@wzhudev wzhudev merged commit 200e655 into dev May 27, 2024
9 checks passed
@wzhudev wzhudev deleted the yuhongz/fix-filter-move-row-col branch May 27, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants