Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rows with empty values are filtered out, even when '<empty field>' is selected #65

Closed
bellma-lilly opened this issue Mar 23, 2023 · 1 comment

Comments

@bellma-lilly
Copy link
Contributor

I am having a problem where empty items in my data are being filtered out, even when <empty fields> is selected. This appears to be caused in filter-data.R, line 475:

        if ("<empty field>" %in% values)
          values[which(values == "<empty field>")] <- ""

Because the value is &lt;empty field&gt; rather than <empty field>
I can make things work as expected with:

emptyField = as.character(as.tags("<empty field>")) 
if(emptyField %in% values)
           values[which(values == emptyField)] <- ""

But I suspect the "right" thing to do is make sure value is <empty field> instead. But I'm not sure how to do that.

@pvictor
Copy link
Member

pvictor commented Jun 19, 2023

Thanks for reporting this, <empty field> was interpreted like HTML tag and escaped.
That's fixed if you re-install from GitHub, soon on CRAN.

Victor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants