Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter warning using data.table, but not data.frame #149

Closed
bthieurmel opened this issue Apr 15, 2021 · 2 comments
Closed

filter warning using data.table, but not data.frame #149

bthieurmel opened this issue Apr 15, 2021 · 2 comments

Comments

@bthieurmel
Copy link

Example :

library(shiny)
library(esquisse)
library(nycflights13)
library(data.table)

ui <- fluidPage(
  tags$h1("Use esquisse as a Shiny module"),
  
  esquisse_ui(
    id = "esquisse", 
    header = FALSE, # dont display gadget title
    controls = NULL,
    container = esquisseContainer(height = "700px")
  )
)

server <- function(input, output, session) {
  
  # warning passing data.table
  data_rv <- reactiveValues(data = data.table(nycflights13::flights[1:20000,]), name = "iris")
  
  # no warning passing data.frame !
  # data_rv <- reactiveValues(data = nycflights13::flights[1:20000,]), name = "iris")
  
  esquisse_server(
    id = "esquisse", 
    data_rv = data_rv
  )
  
}
shinyApp(ui, server)

image

@bthieurmel
Copy link
Author

bthieurmel commented Apr 15, 2021

Moreover, I think that filter computation is processed even if disable in controls (but not showed as expected)

@pvictor
Copy link
Member

pvictor commented Apr 15, 2021

First issue was in {datamods}, should work if you re-install from GitHub:

remotes::install_github("dreamRs/datamods")

and now filters should not be created if the panel is disabled (you need to re-install esquisse from GitHub as well)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants