Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example code with getEffortsbySegmentId() runs out Strava API request limit #42

Closed
gki opened this issue Aug 15, 2020 · 1 comment
Closed

Comments

@gki
Copy link

gki commented Aug 15, 2020

Problem

I tried to run example code of this lib and when I tapped "Segments" button several times, Strava API started to return an error below.

{"message":"Rate Limit Exceeded","errors":[{"resource":"Application","field":"rate limit","code":"exceeded"}]}

Also, Strava web app shows the number of API requests are extremely high during 15min. (In 2nd graph, the number of requests are around 2500 during 15 min, although I've set up this Strava API just now!!)

スクリーンショット 2020-08-15 16 20 42

As debugging result, a do-while loop in SegmentEfforts#getEffortsbySegmentId() seemed to did infinite loop.

Suggestion

If this API will support retry capability, I recommend to have the default "max retry count”. Otherwise, the user of this library may runs out API request limit in very short time unexpectedly, like me.

@BirdyF
Copy link
Collaborator

BirdyF commented Aug 15, 2020

Hi @gki
Sorry for the trouble.
I will try to fix the problem as soon as I have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants