Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VirusTotal detection #841

Open
wopox1337 opened this issue Jun 23, 2021 · 8 comments
Open

VirusTotal detection #841

wopox1337 opened this issue Jun 23, 2021 · 8 comments

Comments

@wopox1337
Copy link
Collaborator

@jeefo
Copy link

jeefo commented Sep 8, 2021

As for easy fix, you can switch to v141_xp toolset, and inject version-info for each binary in windows build.

Result: https://www.virustotal.com/gui/file/43bd19869fc264a177bfc7b6c3c54fd12da9c505da944538bdac0d47e9fa3de7/details

As for hltv.exe (and occasionally hlds.exe), these files should be signed with valid certificate to get more trust from AV vendors.

@stambeto2006
Copy link

@s1lentq @wopox1337 When will you fix the problem so that we can use the latest versions for Windows as well, not just Linux?

@stambeto2006
Copy link

Is this problem expected to ever be fixed?

RauliTop referenced this issue Oct 25, 2021
* Update pr_edict.h

* Update pr_edict.cpp

* Update rehlds_api_impl.cpp

* Update rehlds_api_impl.h

* Update rehlds_api.h

* Update pr_edict.h

* Update pr_edict.cpp

* Update rehlds_api_impl.cpp

* Update rehlds_api_impl.h

* Update rehlds_api.h

* Update pr_edict.cpp
@RauliTop
Copy link
Contributor

As for easy fix, you can switch to v141_xp toolset, and inject version-info for each binary in windows build.

Result: https://www.virustotal.com/gui/file/43bd19869fc264a177bfc7b6c3c54fd12da9c505da944538bdac0d47e9fa3de7/details

As for hltv.exe (and occasionally hlds.exe), these files should be signed with valid certificate to get more trust from AV vendors.

Please @wopox1337 review this and enable again Windows builds

@wopox1337
Copy link
Collaborator Author

Unfortunately, it doesn't help

@stambeto2006
Copy link

Unfortunately, it doesn't help

Some time ago, how did we use the version for windows, and now it's as if it's not supported and we can't use the new things and improved things? How long?

@RauliTop
Copy link
Contributor

Unfortunately, it doesn't help

Some time ago, how did we use the version for windows, and now it's as if it's not supported and we can't use the new things and improved things? How long?

You can download the artifacts at Actions

@TheStormN
Copy link

@wopox1337 Can you just separate the packages?

For example have: rehlds-bin-win32-VERSION_NUM.zip and rehlds-bin-linux-VERSION_NUM.zip?

This way the Windows build will still be easily downloadable and the Linux version will not be flagged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants