Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS(?) issue on Edit Tags page #3359

Closed
kareila opened this issue May 18, 2024 · 2 comments
Closed

JS(?) issue on Edit Tags page #3359

kareila opened this issue May 18, 2024 · 2 comments

Comments

@kareila
Copy link
Member

kareila commented May 18, 2024

https://www.dreamwidth.org/support/see_request?id=48875

As described: when using the Edit Tags page and clicking to add an existing tag that contains an apostrophe, everything following the apostrophe gets dropped from the tag text. Hand-typing or copy-pasting the name of the tag works as expected.

@momijizukamori
Copy link
Contributor

that does sound like a JS issue, but - looking at https://github.com/dreamwidth/dreamwidth/pull/3316/files when I converted the page, I didn't rewrite the JS (which has not, in fact, been touched in 14 years). So something with the old code is interacting weirdly with having the full foundation JS on the page.

(honestly tempted to just rewrite it with the interface we have for tags on the new entry page...)

@kareila
Copy link
Member Author

kareila commented May 22, 2024

Fixed by #3365

@kareila kareila closed this as completed May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants