Fix another uninitialized value warning in LogItems.pm

Use of uninitialized value $valid_types in substitution (s///) ... cgi-bin/DW/Logic/LogItems.pm line 81. (I think this was masked before because using uc on an undefined variable resulted in the empty string.)
dreamwidth · Sep 7, 2015 · d387711 · d387711
1 parent 9645a5c
commit d387711
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/cgi-bin/DW/Logic/LogItems.pm b/cgi-bin/DW/Logic/LogItems.pm
@@ -78,7 +78,7 @@ sub watch_items
         $valid_types ||= uc $args{showtypes} if defined $args{showtypes};
 
         # make (F)eeds an alias for s(Y)ndicated
-        $valid_types =~ s/F/Y/g;
+        $valid_types =~ s/F/Y/g if defined $valid_types;
 
         # load u objects for all the given
         LJ::load_userids_multiple([ map { $_, \$friends_u->{$_} } keys %$friends ], [$remote],