Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank space missing after comma in credit module #1478

Closed
ninetyd opened this issue Jul 6, 2015 · 5 comments
Closed

Blank space missing after comma in credit module #1478

ninetyd opened this issue Jul 6, 2015 · 5 comments

Comments

@ninetyd
Copy link

ninetyd commented Jul 6, 2015

In Core2, in function print_module_credit(), there should be a blank space after the comma in:

else { $ret = $ret + ","; }

Easiest fix ever or what?! :)

@kaberett
Copy link
Contributor

kaberett commented Jul 6, 2015

##curated: beginner

@dteklavya
Copy link
Contributor

I'm claiming this one. Can someone please specify how to reproduce the issue? It looks like a simple fix but just need to make sure it actually fixes it :)

BTW, I'm new to DW.

@ninetyd
Copy link
Author

ninetyd commented Jul 11, 2015

Hi and welcome! When you use an official DW style (https://www.dreamwidth.org/customize/), you have a module section called 'credit' which appears in your sidebar. If the style lists several resources, they're separated by a comma but it lacks a space after the comma. You can see this on one of my testing accounts for example: https://experiment.dreamwidth.org/

For info, the file to edit is /styles/core2.s2

Hope I've been clear enough! :)

@rahaeli
Copy link
Contributor

rahaeli commented Jul 11, 2015

Quick note: once you make the change, you'll need to recompile core2 to see your changes. You can do that by running bin/upgrading/update-db.pl as the dw user. (You need to recompile every time you change core2 or else the changes won't take.)

@dteklavya
Copy link
Contributor

Claiming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

6 participants