Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Select modification level for answer from faqedit #1524

Closed
zarhooie opened this issue Aug 7, 2015 · 14 comments
Closed

Remove Select modification level for answer from faqedit #1524

zarhooie opened this issue Aug 7, 2015 · 14 comments

Comments

@zarhooie
Copy link

zarhooie commented Aug 7, 2015

The modification level drop down is useless for us. The only use I can possibly see is for forked projects who do use translators. Let's look into removing it.

@rahaeli
Copy link
Contributor

rahaeli commented Aug 8, 2015

Yeah, unless @zorkian has an objection I say kill it.

There's also a severity on /admin/translate but I think that's more baked into the system. We should be ok with just removing the dropdown on the faqedit page. (Might also require setting a default severity for the change, because the translation system does expect a severity and it might result in weirdness if it's not there, but it would be ok to just set everything to no-notify behind the scenes.)

Fun fact: The translation system has four severities. The FAQ edit page has three severities. They're named different things. Nobody ever had any idea how they mapped onto each other. Ia, ia, translation system fth'a'gn, etc.

@zarhooie
Copy link
Author

zarhooie commented Aug 8, 2015

tumblr_mdygm3uten1rjdfzto1_400
NGL, this is what I think of whenever we talk about the translation system. Except the lights are on fire, and the blades are made of candy corn.

@rahaeli
Copy link
Contributor

rahaeli commented Aug 8, 2015 via email

@zarhooie
Copy link
Author

zarhooie commented Aug 8, 2015

And the last time someone ducked into the utility room to flip the breaker for maintenance, they disappeared, leaving only the faint scent of Fresh Rain dryer sheets behind. They showed up in Belize a year later with shock white hair, and a Canadian accent.

@zorkian
Copy link
Member

zorkian commented Aug 8, 2015

purge it with fire.

@me-and
Copy link
Contributor

me-and commented Aug 8, 2015

Eh, I was just playing with the FAQ system anyway, so I might as well claim this.

@me-and
Copy link
Contributor

me-and commented Aug 8, 2015

(Although, unless anyone has any objection, if the desire is to burn anything relating to the translation system with fire, I might see how difficult it is to remove the field entirely, rather than just pretending it isn't there and filling it in behind the scenes.)

@zarhooie
Copy link
Author

zarhooie commented Aug 8, 2015

Knowing the translation system, prodding at it in any way might change all the site text to Greek. (But hey, sounds good to me. Probably get a sign-off from The Tallest, though.)

@rahaeli
Copy link
Contributor

rahaeli commented Aug 8, 2015

I have no objections to getting rid of severity more widely, but I don't think it will be a simple fix.

@rahaeli
Copy link
Contributor

rahaeli commented Aug 8, 2015 via email

@kareila
Copy link
Member

kareila commented Aug 11, 2015

Hey @me-and - are you still interested in submitting the fix for this, or should I use mine?

@me-and
Copy link
Contributor

me-and commented Aug 11, 2015 via email

@kareila
Copy link
Member

kareila commented Aug 11, 2015

I'll submit my simple fix using html_hidden, and you can open a separate issue for removing the column from the database if you're still interested in investigating that. 💣

@kareila
Copy link
Member

kareila commented Aug 11, 2015

WTF iPad menu jumping like a jumping thing. Sorry about the wacky reassignments there.

kareila added a commit to kareila/dreamwidth that referenced this issue Aug 11, 2015
Always use severity zero instead of prompting the user to choose.

Fixes dreamwidth#1524.
zorkian added a commit that referenced this issue Aug 11, 2015
[#1524] remove modification level dropdowns from faqedit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

8 participants