[#1134] Use protocol-relative URL for image objects in S2 #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afuna
changed the title
This means that we cache it as "//" rather than "http://" or "https://" so it works both pages. A bit hacky, but makes sure we're limited in scope to website-only (journals only), and not affecting stuff like email. Fixes dreamwidth#1134.
afuna
force-pushed
the
s2-imgroot-cache-bug-1134
branch
from
b6cb9f1
to
831f293
Compare
|
@zorkian this was the IMGROOT caching code you were referring to before right? or was there something else? |
|
Yup this was it! |
zorkian
added a commit
that referenced
this pull request
Jan 25, 2015
[#1134] Use protocol-relative URL for image objects in S2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that we cache it as "//" rather than "http://" or "https://"
so it works both pages.
A bit hacky, but makes sure we're limited in scope to website-only
(journals only), and not affecting stuff like email.
Fixes #1134.