Fix OpenID login error on live site #1460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per discussion in dreamwidth#1355, trying to log in with OpenID in production currently results in the following error: Not an ARRAY reference at /home/dw/current/extlib/lib/perl5/Net/DNS/Paranoid.pm line 91. My understanding of the problem is that LWP::UserAgent::Paranoid has a different argument format for its blocked_hosts method than LWPx::ParanoidAgent did, and the arguments need to be enclosed in an arrayref. I can't reproduce the error exactly in testing on my development environment, but I believe this will at least get us back to where we were before, where at least non-SSL OpenID logins would still work.
afuna
added a commit
that referenced
this pull request
Jun 28, 2015
Fix OpenID login error on live site
|
Okay, going to get this live tonight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in #1355, trying to log in with OpenID in production currently
results in the following error:
My understanding of the problem is that LWP::UserAgent::Paranoid has a different argument
format for its blocked_hosts method than LWPx::ParanoidAgent did, and the arguments need
to be enclosed in an arrayref. I can't reproduce the error exactly in testing on my
development environment, but I believe this will at least get us back to where we were
before, where at least non-SSL OpenID logins would still work.