fix code conversion bugs #2069
Merged
fix code conversion bugs #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…words This method uses wantarray to determine whether to return an array or a string of keywords joined by commas. Template Toolkit method calls will always request array context, unless you use the Scalar plugin to force scalar context. http://mail.template-toolkit.org/pipermail/templates/2008-June/010235.html
Looks like the 'store' method expects a reference to whatever data it is given - in this case, a frozen hashref. If it doesn't get exactly what it expects, it croaks, and any subsequent processing is aborted. This fixes the reported problem in my testing, using the case of not having enough icon slots to import all of the other account's icons. Fixes dreamwidth#2041.
kareila
added a commit
to kareila/dreamwidth
that referenced
this pull request
Apr 5, 2017
I used this to test my fix for dreamwidth#2069 and thought it would be generally useful for development.
zorkian
reviewed
Apr 6, 2017
| @@ -15,6 +15,8 @@ | |||
|
|
|||
| [%- dw.need_res( "stc/editicons.css", "js/editicons.js" ) -%] | |||
|
|
|||
| [%- USE Scalar; # needed to force scalar return context for keywords -%] | |||
|
Thanks for finding/fixing the BlobStore issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2041: DW::BlobStore->store was being given
$datawhen it wanted\$data.Also fixes an issue with printing icon keywords on the newly converted editicons page which was revealed during testing. (All of my previous test icons had single keywords, and the bug only happens when an icon has multiple keywords.)