[#2095] temporarily disable LJRossia crossposts #2104
Conversation
This removes LJRossia from the "Add External Account" form and preemptively fails any attempts to crosspost there. The reason for doing this is because the crosspost attempt is returning a confusing message to the user about not being able to locate LJ/XMLRPC.pm on the remote site.
It turns out that failing the job doesn't automatically notify the user, so make sure to send a notification to inform the user of the current situation.
| }; | ||
|
|
||
| # LJRossia is temporarily broken, so skip - but we do want to notify | ||
| if ( $acct->externalsite && $acct->externalsite->{sitename} eq 'LJRossia' ) { |
There was a problem hiding this comment.
Wow, is this really the best way of doing this?! Hardcoding like this feels pretty sad, but I guess the original design of the xpost system didn't take into account that we might want to administratively disable things? I don't recall thinking of this use case :)
|
If we remove it from the external sites list entirely, then all the other functionality provided by DW::External::Site, like userheads, will stop working as well. |
|
We have no way to say 'this is an external site that doesn't allow crossposting'? I could have sworn that was a flag we had to turn on or off? |
|
It's dependent on "servicetype" - if we update the list to say it's not an LJ-based site, that will do it, but that's (a) less obviously temporary and (b) might cause other problems. |
|
Makes sense. Thanks for thinking about it! |
This removes LJRossia from the "Add External Account" form and preemptively fails any attempts to crosspost there.
It turns out that failing the job doesn't automatically notify the user, so we also make sure to send a notification to inform the user of the current situation.
Fixes #2095.