Update bundled CMB2 and CMB2 Conditionals #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I submitted some PRs to the CMB2 Conditionals repo to fix the incompatibilities (jcchavezs/cmb2-conditionals#69, jcchavezs/cmb2-conditionals#68, jcchavezs/cmb2-conditionals#70), and they were all merged, so I updated the bundled version in your plugin which should fix the issues when loaded with the Visual Composer plugin. (re: this issue: https://wordpress.org/support/topic/wordpress-5-0-2-4/#topic-11069144-replies)
I also updated the bundled CMB2 plugin as it was a few versions old, and also using the development version (
CMB2_Bootstrap_242_Trunk).You'll of course have to update the versions/etc and bundle for release. Hope this helps!