Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Improvements #2

Open
darewreck54 opened this issue Jan 1, 2020 · 0 comments
Open

Possible Improvements #2

darewreck54 opened this issue Jan 1, 2020 · 0 comments

Comments

@darewreck54
Copy link

There is just a list of suggestion that I have while using your library..

Suggestion

  1. In the decorator, it requires to add the project-id and the api token. From looking at the code, it looks like project-id is really the file-key. Update project-id to be called 'file-key'
  2. Update readme to show people how to debug issue if it does not work. Ex. I had to go to https://www.figma.com/developers/api#get-images-endpoint to validate if my file-key and my node-id was correct.
  3. Update what the fields are suppose to represent for the figma configuration
  4. Pass the project-id/file-key in the figma configuration vs. the decorator register call. This allows users to add a global decorator with the API token and access different files within the figma.
  5. It's strange that the string ids are ',' separated but the names are not. Why not just make it an array as well to be consistent.

Thanks,
Derek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant