Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use on MCBE 1.17.10 with 3.22.0 PocketMine-MP #9

Closed
quydrop opened this issue Jul 16, 2021 · 8 comments
Closed

Can't use on MCBE 1.17.10 with 3.22.0 PocketMine-MP #9

quydrop opened this issue Jul 16, 2021 · 8 comments
Labels

Comments

@quydrop
Copy link

quydrop commented Jul 16, 2021

NPC Form can't use on 1.17.20 version, i think because of this update
SmartSelect_20210716-113403_Chrome
Can you update it, please?

@dresnite dresnite added the todo label Jul 17, 2021
@quydrop
Copy link
Author

quydrop commented Jul 25, 2021

Please, update it :(((

@Julooooooos
Copy link

Can you please update the plugin ? I'm having the same issue..

@ananinys
Copy link

you can wait, this problem cannot be solved, as this is a minecraft bug.
the generous thebigsmileXD provided information on this
https://bugs.mojang.com/browse/MCPE-135686

@royaljacques
Copy link

solved ?

@inxomnyaa
Copy link
Collaborator

you can wait, this problem cannot be solved, as this is a minecraft bug. the generous thebigsmileXD provided information on this bugs.mojang.com/browse/MCPE-135686

i don't think that bug is actually the issue here. I am pretty much struggling to get the forms to show in 1.19.2, and i am not sure if it is the game, the packet or my pull request that messed it up. I know for sure that they work fine in singleplayer.

@inxomnyaa
Copy link
Collaborator

Update on this, Galaxite and NetherGames have them still functioning, both use it.

  • The interaction or action tag is not needed anymore, it's handled directly by the packet
  • The server initiates the opening of the form
  • I tried sending the opening form, i don't get a packet violation anymore.. nor a crash.. at least currently. But the form still won't show.
  • The InteractPacket::NPC_OPEN doesn't seem to be sent either..

@inxomnyaa
Copy link
Collaborator

Got it working. Forms must be opened by the server now. Since the InteractPacket is broken, i handle PlayerEntityInteractEvent instead, and then open a form, restoring the old functionality. Still have some leftover debug in the code, but button clicks and everything else is working properly now.
Also added some extra functionality like an open listener.
WolvesFortress@d43f216

@inxomnyaa
Copy link
Collaborator

The @WolvesFortress fork has been merged and thus resolved this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants