Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step Runner - command arguments are not partially checked against mocked arguments #43

Open
richardgaunt opened this issue Mar 8, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@richardgaunt
Copy link
Collaborator

Step runner checks for whether the mocked arguments from the step definition are equal rather than contain the command arguments.

The documentation says it should be checking for whether the command's arguments contain the mocked argument.

see step helper: https://github.com/drevops/bats-helpers/blob/main/src/steps.bash#L196

see docs: https://github.com/drevops/bats-helpers/blob/main/docs/step-runner.md?plain=1#L59

Should change step helper to assert_contains rather than assert_equal

@richardgaunt richardgaunt added the bug Something isn't working label Mar 8, 2024
@richardgaunt richardgaunt changed the title Step Runner - checks to see whether the steps mocked arguments are equal rather than whether the Step Runner - command arguments are not partially checked against mocked arguments Mar 8, 2024
@richardgaunt
Copy link
Collaborator Author

See #44 for PR fixing this.

It may have breaking changes if users are relying on equality of arguments rather than a partial match

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant