Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker builds should use the same binary as the goreleaser builds #278

Open
drewhammond opened this issue Nov 23, 2023 · 0 comments
Open

Comments

@drewhammond
Copy link
Owner

This is fall out from the broken docker builds that were fixed recently. In order to get them working again, we started building the docker images on release "publish" actions. By the time this happens, Github has already built a set of binaries to attach to the release page.

There isn't a functional difference between the builds (at least not intentionally), but for security reasons we should ensure the binaries built into the docker image match the checksums of the binaries built for the release page.

Ideally this would all be handled in GoReleaser, but that's how I managed to break the docker builds in the first place 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant