Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is not so good to share api_key in "Invalid MailChimp API key {$api_key} supplied." message #229

Closed
ildar-aim opened this issue Feb 19, 2018 · 5 comments

Comments

@ildar-aim
Copy link

throw new \Exception("Invalid MailChimp API key `{$api_key}` supplied.");

It may be a private information of merchants.

@drewm
Copy link
Owner

drewm commented Feb 19, 2018

I think this will most likely happen for developers during development, as they get things correctly configured. But yes, you're right. Perhaps we should rethink how that works.

@Pixney-William
Copy link
Contributor

The extra information (the key) is not needed. Simple statement that the key is invalid is enough. As a developer you know what to look for from that message.

@drewm
Copy link
Owner

drewm commented Feb 23, 2018

Ok, great. So is either of you going to make the change?

@Pixney-William
Copy link
Contributor

#231

@drewm
Copy link
Owner

drewm commented Feb 23, 2018

Thanks both.

@drewm drewm closed this as completed Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants