Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique global identifiers on a per-entity basis. #2

Closed
drewmccormack opened this issue Oct 4, 2013 · 1 comment
Closed

Unique global identifiers on a per-entity basis. #2

drewmccormack opened this issue Oct 4, 2013 · 1 comment
Labels
Milestone

Comments

@drewmccormack
Copy link
Owner

The CDEEventBuilder class currently uniques global identifiers across all entities. It would be better to unique on a per-entity basis.

Eg. It is conceivable that a Tag class might have a global identifier the same as its text (e.g. Car). Another entity may have a similar approach, and a conflict on the global identifier is likely to occur.

@drewmccormack
Copy link
Owner Author

Fixed in 70cfddc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant