-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cautionary note about dropping preloads - distinct required? #44
Comments
Thanks for the detailed explanation. I agree on adding a note in the readme. Would you like to take a pass at it in a PR? If so I'd be happy to merge it. |
Gladly. However, our specific use case might be a bit more involved and is more related to proper pagination when joins are involved so that repeated rows are avoided while maintaining the true count. This seemed to address something similar: Did it ever make it into the code base here? The SQL we need to execute is something like the following:
Any suggestions? |
I'll attempt to implement the solution proposed from that old pull request unless a better approach is recommended. |
Thanks for the great library. I was recently building a query and noticed a small quirk.
Notice that by excluding the preloads, the count jumps. This is likely because the joins are kept, but the removal of preloads results in duplicate rows during the count query.
Adding distinct removes the issue.
Should a small note be made in the readme about it?
The text was updated successfully, but these errors were encountered: