Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPE FTP command not implemented #229

Open
ghost opened this issue May 4, 2021 · 1 comment
Open

APPE FTP command not implemented #229

ghost opened this issue May 4, 2021 · 1 comment
Milestone

Comments

@ghost
Copy link

ghost commented May 4, 2021

Describe the bug
APPE FTP command not implemented.

To Reproduce
Steps to reproduce the behavior:
Log on FTP
Execute :

APPE
[R] 502 Command not implemented.

DrFTPD

  • DrFTPD version [4.0.1]

Additional context

From servu-u :

APPE FTP command
A client issue the APPE command after successfully establishing a data connection when it wishes to upload data to the server. The client provides the file name it wishes to use for the upload. If the file already exists on the server, the data is appended to the existing file. If the file does not exist, it is created.

Common responses:

110, 125, 150
226, 250
421, 425, 426, 450, 451
500, 501, 502, 530, 534, 535, 551, 552

https://www.serv-u.com/resource/tutorial/appe-stor-stou-retr-list-mlsd-mlst-ftp-command

@ghost ghost added the enhancement label May 4, 2021
@ghost ghost added this to the 4.0.X-dev milestone May 4, 2021
@ghost ghost changed the title XCUP FTP command not implemented APPE FTP command not implemented May 4, 2021
@hrxcodes
Copy link
Contributor

hrxcodes commented May 4, 2021

I don't see a usecase for this in drftpd. My suggestion is removing the TODO comments and obsolete commented code.
I'm guessing most of the users are running zipscript anyways, so the file would be invalidated and removed if left incomplete. So there would not be a chance to APPEND to it before it's deleted by zipscript

@mvangoor mvangoor modified the milestones: 4.0.X-dev, 4.1.0 May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants