Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checked line checkbox does not have a hover state #12

Closed
samvasko opened this issue Apr 10, 2013 · 4 comments
Closed

Checked line checkbox does not have a hover state #12

samvasko opened this issue Apr 10, 2013 · 4 comments

Comments

@samvasko
Copy link
Contributor

Great work in general, really like it.
I noticed that you are using same css for line checkbox and radio. But therefore checkbox is missing hover state while unchecked. I think this can be solved just by adding iradio class and minor css change. Or creating whole new iradio_line, what do you think?

@drgullin
Copy link
Owner

There's a hover state for both types on unchecked state.

@samvasko
Copy link
Contributor Author

indeed, but checkbox should have one, radio should not
(this could be a feature, not a bug, but for me hover state implies functionality which is at checkboxes)

@aleksandar-trajkov
Copy link

I also agree that the checkboxes should have hover effect when they are selected, it would be good for overall usability (the effect would be lost on radio buttons, though)

@drgullin
Copy link
Owner

Fixed in f5da1d7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants